fix: CSS ordering inconsistency between dev and production build#564
Open
yurii-vasyliev wants to merge 2 commits intomainfrom
Open
fix: CSS ordering inconsistency between dev and production build#564yurii-vasyliev wants to merge 2 commits intomainfrom
yurii-vasyliev wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Vite dev mode, CSS from SCSS modules (e.g.
TableFilter.module.scss) is injected as inline<style>tags following the JS module import order. This means custom classes like.togglenaturally appear after Vanilla Framework styles and win the cascade.In production builds, Vite extracts CSS into separate files where chunk ordering is not guaranteed. Vanilla Framework's button selectors (e.g.
.p-button--base with margin: 0 1rem 1.25rem 0) can appear after our module styles, overriding them due to equal specificity + later source order. This causes visual regressions that only appear in deployed environments, but not on localhost.Solution
Wrap Vanilla Framework's CSS output in a @layer vanilla block. Per the CSS cascade spec, unlayered styles always take priority over layered styles, regardless of specificity or source order. This means that all CSS Modules and custom partials automatically win over Vanilla's rules without needing specificity hacks like doubled selectors (
.toggle.toggle) or!important.Release Impact
According to the Landscape Server Release Cycle, this change will target the following release cycle:
dev/main(Beta)Checklist
pnpm changesetand committed the resulting.mdfile.scripts/).Versioning Reminder
Important
This repository now uses CalVer ($YY.0M.Point.Patch$ ).
Please ensure your changeset description is clear, as it will be automatically added to the
CHANGELOG.mdupon merging tomain.