feat(pragma): consume annoucement#1967
Conversation
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
|
The light theme looks ok, though a little sad and boring with the thick border. Especially compared to the previous version right above:
After switching to the dark theme, the component does not adjust to it properly:
FYI @advl |
|
Hi this is the current WIP styling for "announcement" . We are going for a background color - but we felt atm it's too intense so we are still looking at a possible lighter shade. https://www.figma.com/design/WGHcOmGMEUF9hMAEoRafL8/%F0%9F%93%95-Pragma---documentation-visuals?node-id=3102-3204&t=7GnSWYgZltNgvzJo-1
and dark mode:
|
Thanks for the reply. I see now that the announcement in storybook is still under experimental. @kimanhou should we treat this as an experiment not to be merged atm then? Did you communicate the problems that made the custom styling necessary? |
|
@edlerd FYI many components in storybook lack the styling layer and are yet to go through design QA > best way to find the source of truth is in coda, where we embedded links to the styling instructions (where available). |
Yes, of course. This PR should not be merged. @advl @diana-stanciulescu
|




Done
Both Notification and Announcement are displayed to easily compare them.
QA
Screenshots