Skip to content

feat(pragma): consume annoucement#1967

Draft
kimanhou wants to merge 1 commit intocanonical:mainfrom
kimanhou:WD-35869-pragma-consume-one-component
Draft

feat(pragma): consume annoucement#1967
kimanhou wants to merge 1 commit intocanonical:mainfrom
kimanhou:WD-35869-pragma-consume-one-component

Conversation

@kimanhou
Copy link
Copy Markdown
Contributor

Done

  • Use Pragma's Annoucement instead of Notification in instance configuration > Devices > GPU

Both Notification and Announcement are displayed to easily compare them.

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Go to an instance configuration > Devices > GPU

Screenshots

image image

Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
@webteam-app
Copy link
Copy Markdown

@edlerd
Copy link
Copy Markdown
Collaborator

edlerd commented Apr 22, 2026

The light theme looks ok, though a little sad and boring with the thick border. Especially compared to the previous version right above:

image

After switching to the dark theme, the component does not adjust to it properly:

image

FYI @advl

@diana-stanciulescu
Copy link
Copy Markdown

diana-stanciulescu commented Apr 22, 2026

Hi this is the current WIP styling for "announcement" . We are going for a background color - but we felt atm it's too intense so we are still looking at a possible lighter shade. https://www.figma.com/design/WGHcOmGMEUF9hMAEoRafL8/%F0%9F%93%95-Pragma---documentation-visuals?node-id=3102-3204&t=7GnSWYgZltNgvzJo-1

Screenshot 2026-04-22 190429

and dark mode:

Screenshot 2026-04-22 190526

@edlerd
Copy link
Copy Markdown
Collaborator

edlerd commented Apr 22, 2026

Hi this is the current WIP styling for "announcement" . We are going for a background color - but we felt atm it's too intense so we are still looking at a possible lighter shade.

Thanks for the reply. I see now that the announcement in storybook is still under experimental. @kimanhou should we treat this as an experiment not to be merged atm then? Did you communicate the problems that made the custom styling necessary?

@diana-stanciulescu
Copy link
Copy Markdown

diana-stanciulescu commented Apr 23, 2026

@edlerd FYI many components in storybook lack the styling layer and are yet to go through design QA > best way to find the source of truth is in coda, where we embedded links to the styling instructions (where available).

@kimanhou
Copy link
Copy Markdown
Contributor Author

@edlerd

should we treat this as an experiment not to be merged atm then?

Yes, of course. This PR should not be merged.

@advl @diana-stanciulescu
Importing the styles and the library was easy with bun. However, there are two main issues:

  • bun breaks the CI because we don't use it in LXD UI
  • I had to add "@canonical/styles-old": "npm:@canonical/styles@0.24.0" in resolutions in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants