feat(Permissions > Identities): add OIDC configuration from Settings#1974
Open
kimanhou wants to merge 1 commit intocanonical:mainfrom
Open
feat(Permissions > Identities): add OIDC configuration from Settings#1974kimanhou wants to merge 1 commit intocanonical:mainfrom
kimanhou wants to merge 1 commit intocanonical:mainfrom
Conversation
Demo
Jenkins 
demos.haus 
kimanhou
commented
Apr 27, 2026
edlerd
reviewed
Apr 28, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
This works technically and interaction wise very well. Some ideas to drive the design and copy a bit more and few code comments.
kimanhou
force-pushed
the
WD-34784-oidc-config
branch
3 times, most recently
from
e8f446b to
457ab6f
Compare
edlerd
reviewed
Apr 28, 2026
kimanhou
force-pushed
the
WD-34784-oidc-config
branch
5 times, most recently
from
98fc59b to
c9a714d
Compare
edlerd
reviewed
May 1, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
UX seems good, many ideas to streamline and simplify below.
Comment on lines
+1
to
+7
| .page-header__base-actions { | ||
| @include mobile-and-tablet { | ||
| display: flex; | ||
| gap: $sph--large; | ||
| height: fit-content; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This looks like a global unscoped override. Can we namespace it? And why is it needed?
Contributor
Author
There was a problem hiding this comment.
The new button sits weirdly on small screens
Before
After
I scoped it to the Permission Identities page.
kimanhou
force-pushed
the
WD-34784-oidc-config
branch
2 times, most recently
from
8322a7a to
a79fadb
Compare
edlerd
reviewed
May 1, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Thanks this is nearly perfect. Two tiny suggestions. One is a bit bigger. Suggestion about the responsiveness of the multiple buttons in the header. See below for details.
Comment on lines
+2
to
+8
| .page-header__base-actions { | ||
| @include mobile-and-tablet { | ||
| display: flex; | ||
| gap: $sph--large; | ||
| height: fit-content; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I think we should better reduce to an "Actions" dropdown such as on the instance detail page instead of showing the two wide buttons next to each other when the screen width decreases.
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
kimanhou
force-pushed
the
WD-34784-oidc-config
branch
from
a79fadb to
93ce76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
OIDC configurationbuttonQA
OIDC configurationbutton next to "Create TLS Identity".Escshould close the modalScreenshots