feat(cluster member): add disable reason for evacuate & restore buttons#1980
Open
kimanhou wants to merge 1 commit intocanonical:mainfrom
Open
feat(cluster member): add disable reason for evacuate & restore buttons#1980kimanhou wants to merge 1 commit intocanonical:mainfrom
kimanhou wants to merge 1 commit intocanonical:mainfrom
Conversation
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
Demo
Jenkins 
demos.haus 
Kxiru
approved these changes
Apr 28, 2026
Contributor
Kxiru
left a comment
Kxiru
left a comment
There was a problem hiding this comment.
QA LGTM! Just text fixes remaining over button specificity. I suggest using getByRole('button', { name: 'Evacuate cluster member' }).
Kxiru
reviewed
Apr 28, 2026
Contributor
Kxiru
left a comment
Kxiru
left a comment
There was a problem hiding this comment.
QA LGTM! Just text fixes remaining over button specificity. I suggest using getByRole('button', { name: 'Evacuate cluster member' }).
edlerd
reviewed
Apr 28, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Tests need to be adjusted as well. Two suggestions to improve the copy slightly.
| return "Evacuating cluster member..."; | ||
| } | ||
| if (member.status !== "Online") { | ||
| return "Only online members can be evacuated"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return "Only online members can be evacuated"; | |
| return "Member must be online to evacuate"; |
| return "Restoring cluster member..."; | ||
| } | ||
| if (member.status !== "Evacuated") { | ||
| return "Only evacuated members can be restored"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return "Only evacuated members can be restored"; | |
| return "Member must be evacuated to restore"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
EvacuateandRestorebuttonsQA
EvacuateandRestorebuttons when they are disabled. You should get a valid reason.Screenshots
Screencast.from.2026-04-28.10-58-15.mp4