Skip to content

doc: fix intersphinx links (v2-edge)#765

Merged
roosterfish merged 1 commit into
canonical:v2-edgefrom
minaelee:fix-intersphinx-links-v2-edge
May 7, 2025
Merged

doc: fix intersphinx links (v2-edge)#765
roosterfish merged 1 commit into
canonical:v2-edgefrom
minaelee:fix-intersphinx-links-v2-edge

Conversation

@minaelee
Copy link
Copy Markdown

@minaelee minaelee commented May 1, 2025

Fix intersphinx links to point to /microcloud/v2-edge instead of /en/v2-edge per recent changes to site.
Backport of #764

@minaelee minaelee marked this pull request as ready for review May 1, 2025 20:16
@github-actions github-actions Bot added the Documentation Documentation needs updating label May 1, 2025
@minaelee
Copy link
Copy Markdown
Author

minaelee commented May 1, 2025

I see the documentation check failure & am looking into it; looks like the check is running for a standalone SINGLE_BUILD instead of an integrated build.

@minaelee minaelee marked this pull request as draft May 1, 2025 20:52
Copy link
Copy Markdown
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For traceability can you please git cherry-pick -x the commit from #764?

Signed-off-by: Minae Lee <minae.lee@canonical.com>
@minaelee minaelee force-pushed the fix-intersphinx-links-v2-edge branch from 3179420 to e4ed4a3 Compare May 7, 2025 07:51
@minaelee
Copy link
Copy Markdown
Author

minaelee commented May 7, 2025

For traceability can you please git cherry-pick -x the commit from #764?

It's not exactly a backport, the commit from #764 sets PATH_PREFIX to /microcloud/latest, not /microcloud/v2-edge as this one does. Do you still want me to cherry-pick instead?

I see the documentation check failure & am looking into it; looks like the check is running for a standalone SINGLE_BUILD instead of an integrated build.

Looked into it and using SINGLE_BUILD for spellcheck is correct, since we only want to check MicroCloud docs. However, the intersphinx targets for a SINGLE_BUILD set in custom_conf.py were pointing to latest. Fixed this & check passes now; so does the RTD build.

@roosterfish
Copy link
Copy Markdown
Contributor

It's not exactly a backport, the commit from #764 sets PATH_PREFIX to /microcloud/latest, not /microcloud/v2-edge as this one does

You are right, missed this. It's fine like this.

@roosterfish
Copy link
Copy Markdown
Contributor

@minaelee is it ready?

@minaelee minaelee marked this pull request as ready for review May 7, 2025 08:28
@minaelee
Copy link
Copy Markdown
Author

minaelee commented May 7, 2025

@minaelee is it ready?

Yes, thanks!

@roosterfish roosterfish merged commit 3cff99b into canonical:v2-edge May 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation needs updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants