ci(fix): update outdated minio client image in integration tests - #309
Merged
Merged
Conversation
Contributor
🤖 Backport labels populatedLabels to this pull request were added automatically by the When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR. |
This was referenced Sep 22, 2026
Merged
dariofaccin
approved these changes
Sep 22, 2026
MattiaSarti
approved these changes
Sep 22, 2026
Contributor
|
Successfully created backport PR for |
NohaIhab
added a commit
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing MinIO integration checks by updating the client image used inside the temporary
kubectl runpods.The failing tests were creating a one-off MinIO client pod with an outdated image reference. In practice, that image failed to pull in CI, so the integration checks never reached the actual MinIO connectivity assertion. The test was failing before it validated the charm behavior itself.
Logs from the outdated image pull:
Changes
quay.io/minio/mcMINIO_CLIENT_IMAGE = "quay.io/minio/mc"Additional changes
run_probe_pod()helper that runs the one-offkubectl run podand always deletes it in a finally block. This replaces the unreliable--rmflag, which only cleans up on a clean attached exit and leaves pods behind on the failure paths that matter here, this was previously causing name collisions on retries and between adjacent tests.