Skip to content

ci(fix): update outdated minio client image in integration tests - #309

Merged
NohaIhab merged 1 commit into
mainfrom
ci-fix-tests-update-client-image
Sep 22, 2026
Merged

NohaIhab merged 1 commit into
mainfrom
ci-fix-tests-update-client-image

Conversation

@NohaIhab

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the failing MinIO integration checks by updating the client image used inside the temporary kubectl run pods.

The failing tests were creating a one-off MinIO client pod with an outdated image reference. In practice, that image failed to pull in CI, so the integration checks never reached the actual MinIO connectivity assertion. The test was failing before it validated the charm behavior itself.

Logs from the outdated image pull:

  Warning  Failed     43s (x3 over 84s)  kubelet            spec.containers{mc-debug-events}: Failed to pull image "minio/mc": failed to pull and unpack image "docker.io/minio/mc:latest": failed to resolve reference "docker.io/minio/mc:latest": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

Changes

  • Updated the MinIO client image from the stale image reference to the supported registry:
    • quay.io/minio/mc
  • Added a shared image constant in both integration test files:
    • MINIO_CLIENT_IMAGE = "quay.io/minio/mc"

Additional changes

  • Also included a guaranteed cleanup for the pod: Add a run_probe_pod() helper that runs the one-off kubectl run pod and always deletes it in a finally block. This replaces the unreliable --rm flag, which only cleans up on a clean attached exit and leaves pods behind on the failure paths that matter here, this was previously causing name collisions on retries and between adjacent tests.

@ckfbot ckfbot added the backport track/1.10 Backport to track/1.10 label Sep 22, 2026
@ckfbot

ckfbot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

🤖 Backport labels populated

Labels to this pull request were added automatically by the populate-labels.yaml action.

When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR.

@dariofaccin
dariofaccin requested a review from a team September 22, 2026 12:30
@NohaIhab
NohaIhab merged commit 383d893 into main Sep 22, 2026
12 checks passed
@NohaIhab
NohaIhab deleted the ci-fix-tests-update-client-image branch September 22, 2026 14:50
@ckfbot

ckfbot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for track/1.10:

NohaIhab added a commit that referenced this pull request Sep 23, 2026
(cherry picked from commit 383d893)

Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport track/1.10 Backport to track/1.10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants