feat: improvement for monorepos and k8s preset#425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings a few things needed by Tempo but that will be useful in general:
enable-integrationinput: allows skipping integration tests, useful when they're shared by both coordinator and worker and would otherwise run twice (once per charm)k8spreset to test with Canonical k8s instead ofmicrok8s(still supported, but no longer the default)microk8swas having some issues with enabling metallb, so this feels like a better choice overallNote that selecting
k8sas the provider is adding a flag for the Juju controller bootstrap in order to bring in a fix for juju/juju#21664 ; once this is no longer needed, we can remove it.