Skip to content

patch: fix clean-ups on relation departed - #193

Merged
smethnani merged 9 commits into
2/edgefrom
remove_user_fix
Oct 8, 2026
Merged

patch: fix clean-ups on relation departed#193
smethnani merged 9 commits into
2/edgefrom
remove_user_fix

Conversation

@Pepsiqqq

@Pepsiqqq Pepsiqqq commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description of issue or feature:

jira
fixes #189

Solution:

How was this change tested?

  • Manually
  • Unit tests
  • Integration tests

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@Pepsiqqq
Pepsiqqq marked this pull request as ready for review September 28, 2026 07:17
s-mlnk
s-mlnk previously approved these changes Sep 30, 2026
View reviewed changes
Mehdi-Bendriss
Mehdi-Bendriss reviewed Sep 30, 2026
View reviewed changes

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Danylo, i have one main comment

Comment thread opensearch_single_kernel/charms/base.py Outdated
akram09
akram09 reviewed Oct 1, 2026
View reviewed changes

@akram09 akram09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Danylo, couple of comments from me

Comment thread opensearch_single_kernel/charms/base.py Outdated
Comment thread opensearch_single_kernel/charms/base.py Outdated
Comment thread opensearch_single_kernel/charms/base.py Outdated
Comment thread opensearch_single_kernel/events/external_clients.py
Comment thread opensearch_single_kernel/events/external_clients.py Outdated
Comment thread opensearch_single_kernel/events/jwt.py
Comment thread opensearch_single_kernel/events/opensearch.py
Comment thread opensearch_single_kernel/events/peer_cluster.py
smethnani
smethnani reviewed Oct 1, 2026
View reviewed changes

@smethnani smethnani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pepsiqqq ! Left a question and some cosmetic comments. Otherwise lgtm

Comment thread opensearch_single_kernel/charms/base.py Outdated
Comment thread opensearch_single_kernel/events/snapshots.py Outdated
Comment thread opensearch_single_kernel/events/snapshots.py Outdated
akram09
akram09 previously approved these changes Oct 5, 2026
View reviewed changes
smethnani
smethnani previously approved these changes Oct 6, 2026
View reviewed changes
@smethnani
smethnani dismissed stale reviews from akram09 and themself via 2a69dd6 October 7, 2026 05:12
Mehdi-Bendriss
Mehdi-Bendriss reviewed Oct 7, 2026
View reviewed changes

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shams! I have 3 questions otherwise looks good to me

Comment thread opensearch_single_kernel/events/snapshots.py
Comment thread opensearch_single_kernel/events/jwt.py
Comment thread opensearch_single_kernel/events/snapshots.py Outdated
@akram09 akram09 mentioned this pull request Oct 7, 2026
Merged
smethnani
smethnani reviewed Oct 8, 2026
View reviewed changes
Comment thread opensearch_single_kernel/managers/peer_cluster_orchestrator.py
akram09
akram09 approved these changes Oct 8, 2026
View reviewed changes

@akram09 akram09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shams !

@smethnani
smethnani merged commit 9fdb778 into 2/edge Oct 8, 2026
137 of 180 checks passed
@smethnani
smethnani deleted the remove_user_fix branch October 8, 2026 14:52
akram09 added a commit that referenced this pull request Oct 9, 2026
@akram09 @Pepsiqqq @smethnani
patch: Fix status Missing TLS relation when unit is dying (#230)
9e0fdae 
This Pull Request address issue #187 , which shows a status message
"Missing TLS relation" when the unit is dying. It is based on #193

---------

Co-authored-by: Danylo Bereznenko <pepsiqqfanta@gmail.com>
Co-authored-by: smethnani <82812166+smethnani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akram09 akram09 akram09 approved these changes
@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes
@smethnani smethnani smethnani approved these changes
@s-mlnk s-mlnk s-mlnk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scaling down client removes user

5 participants

@Pepsiqqq @akram09 @Mehdi-Bendriss @smethnani @s-mlnk