Repository navigation
Conversation
akram09
marked this pull request as ready for review
September 30, 2026 20:48
akram09
changed the title
Mehdi-Bendriss
left a comment
Mehdi-Bendriss
left a comment
Contributor
There was a problem hiding this comment.
Thanks Akram, 2 comments from my side.
Mehdi-Bendriss
previously approved these changes
Oct 6, 2026
Mehdi-Bendriss
approved these changes
Oct 8, 2026
smethnani
approved these changes
Oct 9, 2026
akram09
deleted the
DPE-11209-Keystore-credentials-are-not-recovered-after-Pod-restart
branch
October 9, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the issue of keystore credentials lost for plugins and backup integration when a pod is restarted. It also address the case of doing a refresh which involves a pod restarting as well. On a pod restart the keystore is again empty and needs to be recovered from the relations. So the solution is to add a function in both the
starthook handler and theupgrade_charmhook handler on K8s. We could technically put only one handler in the StartOpenSearch hook handler. But I don't want to crowd that hook a lot, its already including a lot of logic.