[MISC] Move utils to single kernel#129
Merged
Merged
Conversation
dragomirp
commented
May 24, 2026
Contributor
Author
There was a problem hiding this comment.
To keep the namespace similar.
dragomirp
commented
May 24, 2026
| @@ -1,3 +1,197 @@ | |||
| # Copyright 2025 Canonical Ltd. | |||
| # Copyright 2022 Canonical Ltd. | |||
Contributor
Author
There was a problem hiding this comment.
Old code, so old copyright.
dragomirp
commented
May 24, 2026
| Returns: | ||
| The converted name. | ||
| """ | ||
| return "/".join(label.rsplit("-", 1)) |
Contributor
Author
There was a problem hiding this comment.
Changed from charms to use a single rsplit.
dragomirp
commented
May 24, 2026
Comment on lines
+98
to
+100
| def render_file( | ||
| substrate: Substrates, path: str, content: str, mode: int, change_owner: bool = True | ||
| ) -> None: |
Contributor
Author
There was a problem hiding this comment.
Used also by k8s to render files on the shared volume.
dragomirp
commented
May 24, 2026
Comment on lines
+25
to
+27
| [project.optional-dependencies] | ||
| postgresql = ["httpx; python_version >= '3.12'"] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Extra deps, so not to install for PGB charms.
dragomirp
requested review from
carlcsaposs-canonical,
juju-charm-bot,
marceloneppel and
taurus-forever
and removed request for
a team
marceloneppel
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PRs: