feat: POST endpoint for versions#15
Merged
Merged
Conversation
britneywwc
reviewed
Apr 14, 2026
britneywwc
left a comment
There was a problem hiding this comment.
Should we add a check to ensure that release_date will be before the other supported dates? This could be helpful to prevent user errors
i.e this payload goes through
'{
"release": "2.1.0",
"architecture": ["amd64"],
"release_date": {"date": "2028-06-01"},
"supported": {"date": "2027-06-01"},
"esm_pro_supported": {"date": "2028-06-01"},
"break_bug_pro_supported": {"date": "2029-06-01"},
"legacy_supported": {"notes": "Supported until further notice"}
}'
Collaborator
Author
|
Thanks @britneywwc, great catch/suggestion. I've added the check and related tests, could you check again? |
Skazitron
reviewed
Apr 20, 2026
| validate=Length(min=1), | ||
| ) | ||
| release_date = fields.Nested(DateOrNoteSchema, required=True) | ||
| supported = fields.Nested(DateOrNoteSchema, required=True) |
There was a problem hiding this comment.
{
"release": "7.0.0",
"architecture": ["amd64"],
"release_date": {"date": "2026-06-01"},
"supported": {"date": "not-a-real-date"},
"esm_pro_supported": {"date": "2028-06-01"},
"break_bug_pro_supported": {"date": "2029-06-01"},
"legacy_supported": {"notes": "Supported until further notice"}
}This payload goes through where the date is not a real date. Is this expected behavior?
Collaborator
Author
There was a problem hiding this comment.
Nope, that's a bug. Thanks for catching!
Skazitron
requested changes
Apr 20, 2026
Skazitron
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
ARTIFACT_TYPESto removeotheras an optionpro_supportedwith 2 new fields,esm_pro_supportedandbreak_bug_pro_supportedis_hiddenversion fieldQA
Issue / Card
https://warthogs.atlassian.net/browse/WD-33168