feat: Add DEL endpoint for versions and related tests#19
Merged
Conversation
britneywwc
approved these changes
Apr 23, 2026
britneywwc
left a comment
britneywwc
left a comment
There was a problem hiding this comment.
Thanks this looks good! Left a couple minor comments
|
|
||
|
|
||
| class TestDeleteProductDeploymentVersion(BaseTestCase): | ||
| def test_delete_product_deployment_version_returns_200_with_deleted_payload( |
There was a problem hiding this comment.
Can we shorted this function name? It exceeds flake8 tests
Collaborator
Author
There was a problem hiding this comment.
Oof, this should've been caught by the linter. I've updated package.json
| {"product_slug": "does-not-exist"}, | ||
| ) | ||
|
|
||
| def test_delete_product_deployment_version_deployment_not_found_returns_404( |
There was a problem hiding this comment.
Same comment on the function name here
| } | ||
| }, 404 | ||
|
|
||
| deleted = { |
There was a problem hiding this comment.
Do we want to include parent_product in the delete response as well?
Collaborator
Author
There was a problem hiding this comment.
Makes sense for consistency, added
britneywwc
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
mtruj013
force-pushed
the
delete-version-endpoint
branch
from
6043ecb to
aa0716e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
Issue / Card
https://warthogs.atlassian.net/browse/WD-35419