Skip to content

feat(ConfirmationButton): use KeyboardKey for SHIFT#1353

Closed
kimanhou wants to merge 1 commit intocanonical:mainfrom
kimanhou:WD-35869-keyboardkey-confirmation-button
Closed

feat(ConfirmationButton): use KeyboardKey for SHIFT#1353
kimanhou wants to merge 1 commit intocanonical:mainfrom
kimanhou:WD-35869-keyboardkey-confirmation-button

Conversation

@kimanhou
Copy link
Copy Markdown
Contributor

@kimanhou kimanhou commented Apr 14, 2026

Done

  • Consume KeyboardKey in ConfirmationButton

QA

Pinging @canonical/react-library-maintainers for a review.

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.
Screenshot from 2026-04-14 16-59-25

@webteam-app
Copy link
Copy Markdown

@kimanhou kimanhou force-pushed the WD-35869-keyboardkey-confirmation-button branch 6 times, most recently from 3e2491c to a10c78d Compare April 15, 2026 15:57
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
@kimanhou kimanhou force-pushed the WD-35869-keyboardkey-confirmation-button branch from a10c78d to 1a7460a Compare April 15, 2026 16:02
@kimanhou kimanhou closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants