feat: multiselect improvements#1367
Merged
Ninfa-Jeon merged 2 commits intocanonical:mainfrom Apr 29, 2026
Merged
Conversation
edlerd
reviewed
Apr 29, 2026
Contributor
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Generally LGTM, though some ideas and suggestions to simplify.
Ninfa-Jeon
force-pushed
the
multi-select-improvements
branch
from
80ddfc9 to
a29a5d5
Compare
edlerd
approved these changes
Apr 29, 2026
Contributor
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
LGTM, one more idea to simplify the interface.
Ninfa-Jeon
force-pushed
the
multi-select-improvements
branch
from
a29a5d5 to
9e9eabe
Compare
edlerd
approved these changes
Apr 29, 2026
Ninfa-Jeon
added
Review: Percy +1
Review: Code +1
and removed
Review: Percy needed
Review: Code needed
labels
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps