Skip to content

[PROTOTYPE]: Interim bases#909

Closed
lengau wants to merge 6 commits into
mainfrom
work/ROCKCRAFT-245
Closed

[PROTOTYPE]: Interim bases#909
lengau wants to merge 6 commits into
mainfrom
work/ROCKCRAFT-245

Conversation

@lengau
Copy link
Copy Markdown
Collaborator

@lengau lengau commented Jun 29, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

Comment thread rockcraft/application.py

@property
@override
def command_groups(self) -> list[craft_cli.CommandGroup]:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this somewhere better - this spot was just a cheap hack.

@@ -0,0 +1,101 @@
# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated in utils.py due to some import issues when generating the snap. I can delete this file

Copy link
Copy Markdown
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think there are a few pieces missing:

  1. How do we update archive urls in destructive-mode?
  2. We also need to update the archive urls in the overlay system, like we do for package-repositories
  3. As per bullet point 2 in R4 on the spec, we need to tell craft-parts to pass --ack-unsupported-release when cutting chisel slices.

"ubuntu@20.04",
"ubuntu@22.04",
"ubuntu@24.04",
"ubuntu@25.04",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to support 25.04 (but I'm fine with leaving it in for testing purposes while it's a prototype)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah IDK what versions we want, but 25.04 and 25.10 were a good pair to test current interim and pre-release interim.

I took out the stuff about changes to the bases.

@lengau
Copy link
Copy Markdown
Collaborator Author

lengau commented Jul 3, 2025

@tigarmo

How do we update archive urls in destructive-mode?

Good point. I've added both this and the overlay installer to the lifecycle service.

For production I think we should modify craft-archives to be able to modify the existing /etc/apt/sources.list or /etc/apt/sources.list.d/ubuntu.sources files - that sed command is just a quick hack.

As per bullet point 2 in R4 on the spec, we need to tell craft-parts to pass --ack-unsupported-release when cutting chisel slices.

Thanks, I missed that. Working on it.

@cjdcordeiro
Copy link
Copy Markdown
Contributor

Cross-referencing chisel's complementary implementation for releases that are EOSS: canonical/chisel#238

@lengau
Copy link
Copy Markdown
Collaborator Author

lengau commented Nov 20, 2025

Superseded by #946

@lengau lengau closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants