Skip to content

docs: add fix for sphinx-llm build failures - #29

Merged
medubelko merged 6 commits into
canonical:mainfrom
JordanMG13:patch-1
Sep 18, 2026
Merged

medubelko merged 6 commits into
canonical:mainfrom
JordanMG13:patch-1

Conversation

@JordanMG13

Copy link
Copy Markdown
Contributor

Per: canonical/sphinx-stack#622

  • Have you updated CHANGELOG.md with relevant non-documentation file changes?
  • Have you updated the documentation for this change?

@a-velasco

a-velasco commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

@JordanMG13 Thank you for this addition! Just a quick update - we're close to merging a big refactor/overhaul of the entire troubleshooting section (#27). When that's done, I'll add what you wrote into the new structure and update this PR.

@a-velasco a-velasco added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 15, 2026
@JordanMG13

Copy link
Copy Markdown
Contributor Author

Sounds good, thanks!

@a-velasco a-velasco self-assigned this Sep 15, 2026

@rkratky rkratky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lang. nits. Pre-approving.

Comment thread docs/how-to/troubleshooting/build-errors.rst Outdated
Comment thread docs/how-to/troubleshooting/build-errors.rst Outdated
Comment thread docs/how-to/troubleshooting/build-errors.rst Outdated
Comment thread docs/how-to/troubleshooting/build-errors.rst Outdated
Grammar nit-picks

Co-authored-by: Robert Krátký <robert.kratky@canonical.com>

@jahn-junior jahn-junior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One non-blocking suggestion.

Comment thread docs/how-to/troubleshooting/build-errors.rst Outdated
Consolidate title of section

Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com>
@jahn-junior

Copy link
Copy Markdown
Collaborator

@JordanMG13 The CLA check is reporting that you haven't signed. Could you please review it?

http://www.ubuntu.com/legal/contributors/

That should be the last thing to address before I merge this. 👍

@JordanMG13

Copy link
Copy Markdown
Contributor Author

Ahhh, I've done this through Launchpad but not Github...I'm assuming I have to do it twice then?

@JordanMG13

JordanMG13 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

I always just thought it was because I was using the Github site and it was using a noreply+github email address, as if I push a commit from my machine (using my SSH key and signed by my GPG key) this issue doesn't occur

EDIT: JordanMG13 (91559220+JordanMG13@users.noreply.github.com)

@medubelko
medubelko merged commit bd8c217 into canonical:main Sep 18, 2026
8 of 9 checks passed
@medubelko medubelko changed the title Add sphinx-llm build failures fix docs: add fix for sphinx-llm build failures Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants