feat: add a default snapcraft.yaml #351
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: starcraft | ||
| version: git | ||
| base: core24 | ||
| summary: Single-line elevator pitch for your amazing snap # 79 char long summary | ||
| description: | | ||
| This is starcraft description. You have a paragraph or two to tell the | ||
| most important story about your snap. Keep it under 100 words though, | ||
| we live in tweetspace and your description wants to look good in the snap | ||
| store. | ||
| confinement: strict | ||
| grade: devel | ||
| license: GPL-3.0 | ||
| compression: lzo | ||
|
Contributor
Author
There was a problem hiding this comment. @lengau I am not sure about this but I understand that the snap taking a bit more space to get a faster start-up time is an interesting trade off for us.
Collaborator
There was a problem hiding this comment. When I measured this for Charmcraft I determined it was pretty irrelevant for our own snaps, so I don't really care either way. (zstd was better for our use case, but alas...) |
||
|
|
||
| platforms: | ||
| amd64: | ||
| arm64: | ||
| armhf: | ||
| riscv64: | ||
| s390x: | ||
| ppc64el: | ||
|
|
||
| apps: | ||
| starcraft: | ||
| command: bin/starcraft | ||
| completer: completion.sh | ||
| plugs: | ||
| - network | ||
| - home | ||
|
|
||
| parts: | ||
| starcraft: | ||
| source: . | ||
| plugin: uv | ||
| build-packages: | ||
| - cargo | ||
| - git | ||
| - libffi-dev | ||
| - libssl-dev | ||
| - pkg-config | ||
| build-snaps: | ||
| - astral-uv | ||
|
upils marked this conversation as resolved.
|
||
| build-environment: | ||
| - UV_COMPILE_BYTECODE: "1" | ||
| - UV_NO_BINARY: "1" | ||
|
|
||
| bash-completion: | ||
| after: [starcraft] | ||
| plugin: nil | ||
| build-environment: | ||
| - PYTHONPATH: $CRAFT_STAGE/lib/python3.12/site-packages | ||
| override-build: | | ||
| python3 -m craft_cli.completion $CRAFT_PROJECT_NAME starcraft.app:get_app_info \ | ||
| > $CRAFT_PART_INSTALL/completion.sh | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we should just put classic here since all of our snaps currently are classic...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered too but then saw that our newest app is
strictand was able to get away with some plugs. So maybe we should keepstrictby default and have the action to set another confinement a conscious decision.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or does a
snapcraft.yamlboilerplate that would work for our apps belong in https://github.com/canonical/craftcraft? It already has one, but is missing recent updates like the parts forlibgit2,git,chisel, and the auto-completer.I'm fine to have starbase's snapcraft.yaml be the absolute minimum to snap a UV project. I'd even be fine to drop the craft-cli autocompleter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that craftcraft was removed, starbase is the next best home but I'm still not convinced it belongs here.
I'm still unsure of the value proposition of this snapcraft.yaml since it's somewhere in between a generic
uvapplication and a craft app.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This semi-generic snapcraft.yaml serves several purposes:
snapcraft.yamlwhen rebasing on starbase and so help harmonize them.