Skip to content

docs: add filter to qa workflow#546

Merged
medubelko merged 1 commit into
mainfrom
work/craft-5211-docs-conditional-ci
Jun 4, 2026
Merged

docs: add filter to qa workflow#546
medubelko merged 1 commit into
mainfrom
work/craft-5211-docs-conditional-ci

Conversation

@medubelko
Copy link
Copy Markdown
Contributor

@medubelko medubelko commented Jun 4, 2026

Add conditionals to skip required checks and unnecessary operations.

For a reason I don't understand right now, the test job is hanging on my fork: medubelko#1. Normally I can test it just fine.


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

Copilot AI review requested due to automatic review settings June 4, 2026 00:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a path-based filter stage to the QA GitHub Actions workflow so downstream reusable lint/test workflows can conditionally skip work (e.g., on docs-only changes).

Changes:

  • Introduces a filter job using dorny/paths-filter to compute a source-files output.
  • Wires lint and test jobs to depend on filter and forwards the computed source-files value as an input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/qa.yaml
Comment thread .github/workflows/qa.yaml
Comment thread .github/workflows/qa.yaml
Comment thread .github/workflows/qa.yaml
@medubelko medubelko requested a review from bepri June 4, 2026 00:56
@medubelko
Copy link
Copy Markdown
Contributor Author

@bepri This one is throwing me another curve ball. I don't know why the matrixed test jobs aren't starting on my fork. All my other forks were able to prove this code works on docs-only changes.

@lengau
Copy link
Copy Markdown
Collaborator

lengau commented Jun 4, 2026

@medubelko if you mean the fact that the tests are running here, it's because qa.yaml got changed. When we modify a workflow that workflow should always run.

@lengau
Copy link
Copy Markdown
Collaborator

lengau commented Jun 4, 2026

[per in-person conversation, I misunderstood. The specific items not running in @medubelko's fork is because they're waiting for a self-hosted runner tag that doesn't exist for his user account]

@medubelko medubelko merged commit ccb17d2 into main Jun 4, 2026
21 of 23 checks passed
@medubelko medubelko deleted the work/craft-5211-docs-conditional-ci branch June 4, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants