Fix #91 bug: Cookie banner not showing#102
Merged
Merged
Conversation
izmalk
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes issue #91 by wiring in third-party assets/snippets intended to enable the cookie consent banner and its “Manage your tracker settings” entry point in the Ulwazi docs theme build.
Changes:
- Included a new analytics/tag-manager template from the header.
- Added a new
components/analytics.htmlwith a Google Tag Manager bootstrap snippet. - Updated
docs/conf.pyto load external cookie banner CSS/JS assets and adjusted the footer “Manage…” link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
ulwazi/theme/ulwazi/sections/header.html |
Adds an include to render the new analytics/tag-manager snippet on every page. |
ulwazi/theme/ulwazi/components/analytics.html |
Introduces the Google Tag Manager script snippet used by the header include. |
docs/conf.py |
Adds external cookie banner CSS/JS and modifies the cookie manager footer link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Improved cookie consent management link. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #91 bug.
Added the cookie banner code to the header/footer and css/js files import in
conf.py.