Update branch URL logic in conf.py#103
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates how the documentation configuration and theme construct GitHub URLs so that links (license, view source, edit source) can target the appropriate branch/tag instead of being hardcoded to main, addressing issue #98.
Changes:
- Introduced
repo_default_branchand computedsource_branch(viaREADTHEDOCS_GIT_IDENTIFIERfallback) to drive GitHub link generation. - Updated license, default edit, and default view URLs in
docs/conf.pyanddocs/default-conf.pyto usesource_branch. - Updated the feedback template to use
repo_branchfor view/edit URLs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ulwazi/theme/ulwazi/sections/feedback.html |
Switches view/edit URL construction to use repo_branch. |
docs/default-conf.py |
Makes license and default view/edit URLs branch-aware via source_branch and exposes it as repo_branch. |
docs/conf.py |
Same branch-aware URL refactor for this repo’s docs build configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #98 and a few other potential bugs.
Refactored the variables for branch selection in URLs.
Updated both
conf.pyanddefault-conf.py.