Skip to content

Update branch URL logic in conf.py#103

Merged
izmalk merged 3 commits into
mainfrom
fix-branch-selection-conf-py
May 8, 2026
Merged

Update branch URL logic in conf.py#103
izmalk merged 3 commits into
mainfrom
fix-branch-selection-conf-py

Conversation

@izmalk
Copy link
Copy Markdown
Collaborator

@izmalk izmalk commented May 6, 2026

Fixed #98 and a few other potential bugs.
Refactored the variables for branch selection in URLs.
Updated both conf.py and default-conf.py.

@izmalk izmalk self-assigned this May 6, 2026
@izmalk izmalk added the bug Something isn't working label May 6, 2026
@izmalk izmalk requested a review from Copilot May 8, 2026 17:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how the documentation configuration and theme construct GitHub URLs so that links (license, view source, edit source) can target the appropriate branch/tag instead of being hardcoded to main, addressing issue #98.

Changes:

  • Introduced repo_default_branch and computed source_branch (via READTHEDOCS_GIT_IDENTIFIER fallback) to drive GitHub link generation.
  • Updated license, default edit, and default view URLs in docs/conf.py and docs/default-conf.py to use source_branch.
  • Updated the feedback template to use repo_branch for view/edit URLs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ulwazi/theme/ulwazi/sections/feedback.html Switches view/edit URL construction to use repo_branch.
docs/default-conf.py Makes license and default view/edit URLs branch-aware via source_branch and exposes it as repo_branch.
docs/conf.py Same branch-aware URL refactor for this repo’s docs build configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ulwazi/theme/ulwazi/sections/feedback.html
Comment thread docs/default-conf.py Outdated
@izmalk izmalk merged commit e858197 into main May 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default conf.py licence block should have branch adaptable

2 participants