feat: change auto update when off to start local binary and make auto update repo check configurable#339
Merged
pablocampogo merged 5 commits intomainfrom Mar 18, 2026
Conversation
… check owner and name configurable
rem1niscence
requested changes
Mar 18, 2026
rem1niscence
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinPathis now mandatory. The auto-updater validates it is present and executable on startup, and fatals with a clear error if it is not. The previous fallback to running the CLI in-process (cli.Start()) has been removed.UpdateLoop. When auto-update is disabled, theReleaseManageris created withEnabled: false, and theUpdateLoopskips update checks on each timer tick via a simplecontinue, avoiding unnecessary logs and GitHub API calls while still handling process lifecycle, signal forwarding, and graceful shutdown.config.json(autoUpdateRepoOwner,autoUpdateRepoName) with fallback to the existing defaults, replacing the previous environment-variable-only approach.