Draft
Conversation
For some reason, in some rare cases, the tag name ends up as being the branch name, rather than QA. Not sure why. These extra checks are a workaround for invalid names making it to Docker.
StevenMaude
commented
Jan 5, 2026
| // 1. Valid chars: a-z, A-Z, 0-9, dot (.), underscore (_), minus (-). | ||
| // 2. Max length: 128 characters. | ||
| // 3. Cannot start with a dot (.) or minus (-). | ||
| func CleanDockerTag(input string) string { |
Contributor
Author
There was a problem hiding this comment.
This may not be the correct place for this.
StevenMaude
commented
Jan 5, 2026
| types.ImageBuildOptions{ | ||
| Remove: true, | ||
| Tags: []string{name}, | ||
| Tags: []string{CleanDockerTag(name)}, |
Contributor
Author
There was a problem hiding this comment.
We could do without having to clean the name twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, in some rare cases, the tag name ends up as being the specific branch name, rather than the target. Not sure why. These extra checks are a workaround for invalid names making it to Docker.