Skip to content

fix: refactor jwt email to authcontext and transaction service#1945

Open
mjuchli-da wants to merge 5 commits into
mainfrom
mjuchli/refactor-jwt-email
Open

fix: refactor jwt email to authcontext and transaction service#1945
mjuchli-da wants to merge 5 commits into
mainfrom
mjuchli/refactor-jwt-email

Conversation

@mjuchli-da
Copy link
Copy Markdown
Contributor

@mjuchli-da mjuchli-da commented Jun 4, 2026

this PR provides refactorings and preparation for #1866

Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
@mjuchli-da mjuchli-da self-assigned this Jun 4, 2026
@mjuchli-da mjuchli-da requested a review from a team as a code owner June 4, 2026 23:07
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
@mjuchli-da mjuchli-da changed the title fix: always attempt to set email in authcontext fix: refactor jwt email to authcontext and transaction service Jun 4, 2026
@pawelstepien-da
Copy link
Copy Markdown
Contributor

Looks good!
I see that some unit tests are failing and I'm pretty sure you intended provider specific signWithX / executeWithX methods in transactionService to be private after you added generic sign and execute, but left them public to keep current unit tests working.
I aligned unit tests with your refactor #1946
Consider merging it with your branch.

@mjuchli-da
Copy link
Copy Markdown
Contributor Author

thank you @pawelstepien-da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants