feat: display action required items in portfolio dashboard#1948
Conversation
| }, | ||
| }} | ||
| > | ||
| <DialogContent sx={{ p: 4 }}> |
There was a problem hiding this comment.
Empty dialog for now, content in the next PR
| display: 'grid', | ||
| gridTemplateColumns: { | ||
| xs: '1fr', | ||
| md: '1fr 1fr 1fr 1fr 1fr', |
There was a problem hiding this comment.
might switch to flex layouts here later as this grid has been giving me headaches
| error: Error | null | ||
| } | ||
|
|
||
| export function useActionRequiredItems(): ActionRequiredItemsResult { |
There was a problem hiding this comment.
This hook is the core of the whole feature. It's where we create the actual data that's displayed. If there's one file to review, it's this 😉 I've also left some comments in the code to help with my cognitive load of constantly reviewing what it does.
Also, most of the code was previously written here by yours truly
fayi-da
force-pushed
the
fayi/1790-action-required-list
branch
from
6663bed to
e966d5c
Compare
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
fayi-da
force-pushed
the
fayi/1790-action-required-list
branch
from
e966d5c to
b1351f9
Compare
| "@tanstack/router-core": "^1.169.2", | ||
| "@tanstack/router-plugin": "^1.167.35", | ||
| "date-fns": "^4.1.0", | ||
| "date-fns": "^4.4.0", |
There was a problem hiding this comment.
tried to avoid it but started writing complex date logic and knew it was time to bring in a date lib. I usually go for dayjs but date-fns is much lighter and we can treeshake unused functions when bundling
1 participant
Part of #1790