ci: add quality gate, track tests, add embed/share smoke tests - #48
Merged
Merged
Conversation
- Stop git-ignoring playwright.config.js and test-tour.spec.js so CI can run the existing e2e suite (previously local-only). - Widen testMatch to *.spec.js and make the config CI-aware (retries, no server reuse, longer webServer timeout). - Ignore ad-hoc dogfood screenshots and dogfood-output/.
Covers the AI-render-layer entry points: embed.html renders from ?text=, shows the zoom toolbar and brand back-link, and the main app loads ?text= into the editor and preview.
Runs on pull_request to main and pushes to non-main branches. Deploy.yml still owns main deployment; this gate blocks regressions before merge.
Deploying mermzen with
|
| Latest commit: |
c3548bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49fce484.mermzen.pages.dev |
| Branch Preview URL: | https://chore-ci-quality-gate.mermzen.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the project's biggest engineering gap: there was no CI quality gate, and the test files weren't even under version control (
playwright.config.js/test-tour.spec.jswere git-ignored, so CI had nothing to run).Changes
playwright.config.jsandtest-tour.spec.js; widentestMatchto*.spec.js; make the config CI-aware (retries, no server reuse, longerwebServertimeout).embed-share.spec.js):embed.html?text=renders an SVG, shows the zoom toolbar and brand back-link; the main app loads?text=into editor + preview. These are the strategic differentiator paths.ci.yml): on PRs tomainand non-mainpushes, runstype-check+build+ Playwright e2e.deploy.ymlstill ownsmaindeployment.dogfood-output/.Test plan
npm run type-check✅npx playwright test✅ — 12 passed (7 tour + 5 new smoke)