Skip to content

Fix QQ login credential defaults and validation - #312

Merged
caoergou merged 1 commit into
mainfrom
issue/310-qq-login-credentials
Jul 31, 2026
Merged

caoergou merged 1 commit into
mainfrom
issue/310-qq-login-credentials

Conversation

@caoergou

Copy link
Copy Markdown
Owner

Summary

  • add optional, data-driven QQ login defaults with the profile number as the account fallback
  • require both account and password before click or Enter can submit
  • support remembered-password presentation state and keep all login copy localized
  • document and export the public configuration, with unit and browser coverage

Root cause

The login panel initialized with empty local state, ignored authored profile credentials, and submitted without validating either field. Hosts therefore could not recreate remembered accounts, while users could enter the simulated client with blank credentials.

Impact

Culture and content authors can prefill a fictional QQ account without putting presentation credentials into the runtime QQ store. Existing profiles remain compatible, and the built-in profile now preselects its QQ number while still requiring a non-empty password.

Validation

  • npm run lint
  • npm run typecheck:strict
  • npx vitest run --maxWorkers=1 --minWorkers=1
  • PW_CHROMIUM_PATH=/opt/google/chrome/chrome npx playwright test e2e/qq.spec.ts --project=chromium --workers=1
  • npm run build:lib
  • npm run size:check

Closes #310

@caoergou
caoergou marked this pull request as ready for review July 31, 2026 09:57
@caoergou
caoergou merged commit bdcc00b into main Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QQ login accepts empty credentials and cannot prefill remembered accounts

1 participant