Restrict file extension change during attachment rename#474
Merged
Conversation
Contributor
|
Hi @deepikaSingh2711, please attach the Screenshot of Integration tests |
Collaborator
Author
I Have added it |
rashmiangadi05
previously approved these changes
May 5, 2026
yashmeet29
reviewed
May 5, 2026
Comment on lines
+150
to
+151
| public static final String FILE_EXTENSION_CHANGE_NOT_ALLOWED = | ||
| "Changing the file extension is not allowed. The file \"%s\" must retain its original extension \"%s\"."; |
Contributor
There was a problem hiding this comment.
@deepikaSingh2711, please add the corresponding key for this error message for translation
yashmeet29
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When renaming an attachment, users could change the file extension (e.g., sample.pdf → sample.dmg), corrupting the document type and making downloaded files unopenable.
Changes:
-> Added getFileExtension() and hasFileExtensionChanged() utilities in SDMUtils
-> Added extension validation in updateFilenameProperty() — if extension changes, the rename is skipped, the filename is reverted to the original, and a warning is shown to the user
-> Applied to both Update and Create handler flows
Behavior:
sample.pdf → report.pdf Allowed
sample.pdf → sample.dmg Warning shown, filename will be reverted
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested
SINGLE TENANT INTEGRATION TEST
https://github.com/cap-java/sdm/actions/runs/25163159892
MULTI TENANT INTEGRATION TEST
https://github.com/cap-java/sdm/actions/runs/25163208769