Move leading app to SDM plugin & workflow files update to read these apps from SDM plugin#504
Merged
Conversation
* Harden GitHub Actions workflows — environment, secret masking & log protection
Security changes applied to all 19 workflow files:
1. environment: dev — All jobs now pull secrets from the protected "dev"
environment instead of repo-level secrets, adding an extra access
control layer. Jobs with existing environment (maven-central) are
kept as-is.
2. Secrets moved from inline ${{ secrets.X }} to env: blocks — Prevents
secret values from appearing in the process argument list (visible via
ps/audit logs). Shell commands now reference $ENV_VAR instead.
3. set +x in every sensitive step — Disables bash debug-trace mode before
any secret variable is assigned, preventing accidental log exposure if
debug mode is ever enabled upstream.
4. ::add-mask:: for all runtime-fetched and copied secret variables —
Registers CF credentials, clientSecret/clientID (fetched from XSUAA
at runtime), usernames and passwords with GitHub's log scrubber so
any accidental echo or error trace is redacted as *** in logs.
* Update pom.xml
* remove .gitignore from leading apps and add mta.yaml back (#505)
Co-authored-by: Yashmeet . <yashmeet@sap.com>
* Update multiTenancyDeployLocal.yml
* Update pom.xml
* modified workflow
* Added retry logic
* Added Retry logic
* modified workflow
* updated sdm version
* Updated sdm version in pom
---------
Co-authored-by: Yashmeet . <yashmeet@sap.com>
vibhutikumar07
temporarily deployed
to
pr-analysis
GitHub Actions
Inactive
vibhutikumar07
temporarily deployed
to
pr-analysis
GitHub Actions
Inactive
vibhutikumar07
temporarily deployed
to
pr-analysis
GitHub Actions
Inactive
vibhutikumar07
temporarily deployed
to
pr-analysis
GitHub Actions
Inactive
vibhutikumar07
temporarily deployed
to
pr-analysis
GitHub Actions
Inactive
vibhutikumar07
temporarily deployed
to
pr-analysis
GitHub Actions
Inactive
akgarg06
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Below are the changes being done as part of this PR:
Changes Made to GitHub Actions Workflows (19 files)
Environment Protection (environment: dev)
Added environment: dev to every job across all workflows so secrets are served from a protected environment instead of repo-level, adding an extra access-control layer. Fork PRs will not receive secrets.
Secrets moved from inline to env: blocks
Replaced all ${{ secrets.X }} references inside shell commands with env: blocks. Values are now injected as environment variables instead of being baked into the process argument string (which is visible in process listings and audit logs).
cf login banner suppressed (> /dev/null)
Appended > /dev/null to all cf login commands to suppress this banner. stderr is unaffected so login failures still surface as errors.
set +x as first line of every sensitive step
Ensures bash debug-trace mode is disabled before any secret variable is assigned, preventing values from being printed if debug mode is ever enabled.
::add-mask:: for all secret-holding variables
Registered every secret-holding shell variable (CF credentials, XSUAA clientSecret/clientID fetched at runtime, test usernames/passwords) with GitHub's log scrubber. This ensures any accidental echo or error trace is redacted as *** in logs. Masks are placed as the very first lines of each run block — before any command that could reference those values.
Type of change
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested
Multitenant Integration Test: https://github.com/cap-java/sdm/actions/runs/26954696460
Single tenant Integration test: https://github.com/cap-java/sdm/actions/runs/26950541261