Skip to content

user defined error msg for maximum upload of attachments #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vibhutikumar07 merged 3 commits into from
Jun 23, 2026
Merged

user defined error msg for maximum upload of attachments #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6a80f7
user defined error msg for maximum upload of attachments
deepikaSingh2711 Jun 18, 2026
11a47cf
Integration test msg changes
deepikaSingh2711 Jun 18, 2026
68906fb
IT fix
deepikaSingh2711 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ti-tenant/central-space/cloud-cap-samples-java/srv/src/main/resources/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ order.exceeds.stock = {0} exceeds stock for book
review.add.forbidden=User not allowed to add more than one review for a given book
book.import.failed = Import of books failed
book.import.invalid.csv = Invalid CSV structure found - Please check its content
SDM.Attachments.maxCountError = Maximum number of attachments reached in English
SDM.maxCountErrorMessage = Maximum number of attachments reached in English
2 changes: 1 addition & 1 deletion ...i-tenant/personal-space/cloud-cap-samples-java/srv/src/main/resources/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ order.exceeds.stock = {0} exceeds stock for book
review.add.forbidden=User not allowed to add more than one review for a given book
book.import.failed = Import of books failed
book.import.invalid.csv = Invalid CSV structure found - Please check its content
SDM.Attachments.maxCountError = Maximum number of attachments reached in English
SDM.maxCountErrorMessage = Maximum number of attachments reached in English
2 changes: 1 addition & 1 deletion app/single-tenant/central-space/demoapp/srv/src/main/resources/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SDM.Attachments.maxCountError = Maximum number of attachments reached in English
SDM.maxCountErrorMessage = Maximum number of attachments reached in English
2 changes: 1 addition & 1 deletion app/single-tenant/personal-space/demoapp/srv/src/main/resources/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SDM.Attachments.maxCountError = Maximum number of attachments reached in English
SDM.maxCountErrorMessage = Maximum number of attachments reached in English
8 changes: 4 additions & 4 deletions sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,7 +2510,7 @@ void testNAttachments_NewEntity() throws IOException {
response = api.saveEntityDraft(appUrl, entityName, srvpath, entityID4);
if (response.equals("Saved")) {
String expectedJson =
"{\"error\":{\"code\":\"500\",\"message\":\"Cannot upload more than 4 attachments.\"}}";
"{\"error\":{\"code\":\"500\",\"message\":\"Maximum number of attachments reached in English\"}}";
ObjectMapper objectMapper = new ObjectMapper();
JsonNode actualJsonNode = objectMapper.readTree(check);
JsonNode expectedJsonNode = objectMapper.readTree(expectedJson);
Expand Down Expand Up @@ -2558,7 +2558,7 @@ void testUploadNAttachments() throws IOException {
System.out.println("Result message for attachment " + i + ": " + resultMessage);

String expectedResponse =
"{\"error\":{\"code\":\"500\",\"message\":\"Cannot upload more than 4 attachments.\"}}";
"{\"error\":{\"code\":\"500\",\"message\":\"Maximum number of attachments reached in English\"}}";
if (resultMessage.equals(expectedResponse)) {
ObjectMapper objectMapper = new ObjectMapper();
JsonNode actualJsonNode = objectMapper.readTree(resultMessage);
Expand Down Expand Up @@ -3979,9 +3979,9 @@ void testCreateLinkFailure() throws IOException {
String errorMessage = json.getJSONObject("error").getString("message");
assertEquals("500", errorCode);
if (facetName.equals("references")) {
assertEquals("Cannot upload more than 5 attachments.", errorMessage);
assertEquals("Maximum number of attachments reached in English", errorMessage);
} else if (facetName.equals("attachments")) {
assertEquals("Cannot upload more than 4 attachments.", errorMessage);
assertEquals("Maximum number of attachments reached in English", errorMessage);
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_SingleFacet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2367,7 +2367,7 @@ void testNAttachments_NewEntity() throws IOException {
response = api.saveEntityDraft(appUrl, entityName, srvpath, entityID4);
if (response.equals("Saved")) {
String expectedJson =
"{\"error\":{\"code\":\"500\",\"message\":\"Cannot upload more than 4 attachments.\"}}";
"{\"error\":{\"code\":\"500\",\"message\":\"Maximum number of attachments reached in English\"}}";
ObjectMapper objectMapper = new ObjectMapper();
JsonNode actualJsonNode = objectMapper.readTree(check);
JsonNode expectedJsonNode = objectMapper.readTree(expectedJson);
Expand Down Expand Up @@ -2415,7 +2415,7 @@ void testUploadNAttachments() throws IOException {
System.out.println("Result message for attachment " + i + ": " + resultMessage);

String expectedResponse =
"{\"error\":{\"code\":\"500\",\"message\":\"Cannot upload more than 4 attachments.\"}}";
"{\"error\":{\"code\":\"500\",\"message\":\"Maximum number of attachments reached in English\"}}";
if (resultMessage.equals(expectedResponse)) {
ObjectMapper objectMapper = new ObjectMapper();
JsonNode actualJsonNode = objectMapper.readTree(resultMessage);
Expand Down Expand Up @@ -3504,7 +3504,7 @@ void testCreateLinkFailure() throws IOException {
String errorCode = json.getJSONObject("error").getString("code");
String errorMessage = json.getJSONObject("error").getString("message");
assertEquals("500", errorCode);
assertEquals("Cannot upload more than 4 attachments.", errorMessage);
assertEquals("Maximum number of attachments reached in English", errorMessage);
}
String response = api.saveEntityDraft(appUrl, entityName, srvpath, createLinkEntity);
if (!response.equals("Saved")) {
Expand Down
Loading