Support interval and maxWaitTime for Android watchers#155
Open
ricardosohn wants to merge 2 commits into
Open
Conversation
feat(android): support interval and maxWaitTime on watchers
|
@jamesdiacono I actually came here to do this exact change myself. Do you mind reviewing it? I've tested it and it works while also being fully backwards compatible |
Contributor
|
Thanks for this, if you could just fix the whitespace, add comments in the definitions file, and update the README with the new options I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the location update configuration by allowing clients to specify custom
intervalandmaxWaitTimevalues for location requests, providing more flexibility over how frequently location updates are received and batched.Location update configuration improvements:
addWatchermethod inBackgroundGeolocation.javanow acceptsintervalandmaxWaitTimeparameters from the plugin call, with sensible defaults if not provided.addWatchermethod inBackgroundGeolocationService.javahas been updated to use the providedintervalandmaxWaitTimevalues when configuring theLocationRequest, and also sets thefastestIntervalto match theintervalfor consistent update timing.