Adding viewBounds function to return map view bounds of all corners i…#171
Adding viewBounds function to return map view bounds of all corners i…#171jjozwiak wants to merge 5 commits intocapacitor-community:mainfrom
Conversation
|
@tafelnl If we get the conflicts resolved on this can we get this merged? |
…n Lat/Lng. Based on contribution by @J-Gonzalez PR capacitor-community#81 but updated to match project structure now being used in main branch
jjozwiak
force-pushed
the
jjozwiak/view-bounds
branch
from
bfefc37 to
7aa39d8
Compare
Changing viewBounds to getViewBounds and adding ViewBoundsResult interface to provide a return type for the getViewBounds method
|
Hi @tafelnl , thanks for the review and feedback. I rebased this branch, resolved merge conflicts, and implemented your feedback. Please let me know if there's anything else. Cheers |
Changing viewBounds to getViewBounds and adding ViewBoundsResult interface to provide a return type for the getViewBounds method
…s into jjozwiak/view-bounds
|
Hi @tafelnl, |
|
Hi @tafelnl. Is there anyway we can get this merged? Trying to take a project to production and would like to use this repo instead of our fork if at all possible. Thank you! |
1 similar comment
|
Hi @tafelnl. Is there anyway we can get this merged? Trying to take a project to production and would like to use this repo instead of our fork if at all possible. Thank you! |
|
@tafelnl Is there something we can do to get this merged? Are we missing something? |
|
Bumping as I'd also like to see this implemented! |
Lot's of code in composition has changed. This is primarily because we don't need `ChannelsListViewModel` logic in the `ChatScreen` anymore. Because when a new ViewModel creation was made, the delegate for the ChannelsListView was pointed to a new ViewModel instance. Which results in no UI updates happening when you navigated back to the `ChannelListView` This also gave me a chance to simplify the code of the composers. For example `ExtendedStreamPlugin` does not compose the channel header view anymore. This is done in `ChatChannelsViewControllerComposer` which makes more sense. also renamed a `ChatChannelsViewControllerComposer ` from `composeWith` to `lazyCompose` so it's more clear that we open a channel and load information on appearance when we only have a channel id to navigate to. which also simplify things. (EDIT) This also solves the issue of the pop-overs and or whole chat closing when the view update by any channel event changes
6 participants
…n Lat/Lng. Based on contribution by @J-Gonzalez PR #81 but updated to match project structure now being used in main branch