fix: render caprover deploy as code in CLI deploy description#216
Merged
githubsaturn merged 1 commit intoJul 16, 2026
Merged
Conversation
Part 2 of the Method 1 CLI help text embedded raw <code> tags inside i18n strings. localize() returns plain text, so React escaped them and users saw literal <code>caprover deploy</code> instead of styled code. Use Utils.formatText with a %s placeholder and a real <code> element, matching part 1. Update locale strings accordingly (and clean de-DE part 1 which had the same raw HTML issue).
Collaborator
|
Thanks! In the future, please include before/after screenshots in the frontend PR as it'd make it easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<code>caprover deploy</code>inside i18n strings.localize()returns plain text, so React escaped the tags and the UI showed the literal string<code>caprover deploy</code>.Utils.formatTextwith a%splaceholder and a real React<code>element.de-DEpart 1, which had the same issue).Test plan
caprover deployrender as styled<code>, not as literal<code>...</code>text