Add resource filtering functionality#14
Draft
ccp-chargeback wants to merge 50 commits intocarbonengine:mainfrom
Draft
Add resource filtering functionality#14ccp-chargeback wants to merge 50 commits intocarbonengine:mainfrom
ccp-chargeback wants to merge 50 commits intocarbonengine:mainfrom
Conversation
Make use of existing filePath test functions
Next step, add missing tests.
Also fixed clang-tidy suggestions
- Do some function name changes to reduce stuttering.
Needed to support: - Empty or undefined top-level filter (which should add a "*" include) - Inline exclude filter ONLY (which should NOT add a "*" include) in the combined output. Fixed and added a bunch of tests
- Hook it up to the ResourceGroupImplementation - Add some basic tests for the functionality
# Conflicts: # include/ResourceGroup.h
- No need as the top-level ResourceGroupImpl one will return the correct top-level error code to the caller.
- The test should cover most (if not all) realistic mutations of same file(s) via different prefixmap relative paths includes/excludes.
Added test for: - validComplexExample1 - combined validSimpleExample1 + validComplexExample1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow filtering of included resource files based on rules defined in one or more supplied filter.ini files.
The change contains: