Conversation
ccp-serpent
requested changes
Oct 16, 2025
ccp-serpent
left a comment
ccp-serpent
left a comment
There was a problem hiding this comment.
The manifest features require further refinement before being approved. I've outlined a potential path forward for this new pattern in order to get the ball rolling. Unfortunately this PR requires special scrutiny due to the fact that it's establishing a new pattern that would be valuable for more components to adopt.
- Make sure tests are ON by default - Re-introduce CTest
- Make tests a default feature - Remove host dependency on gtest and python3 - Introduce a _ci configPreset with tests;docs turned ON
ccptoebeans
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the following changes: