Boxel variables consolidation #3568
Draft
+247
−268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to Review: packages/boxel-ui/addon/src/styles/variables.css
Main changes:
-mdinstead of-medfor mediumexample:
--boxel-font-size-med-->--boxel-font-size-md--boxel-lineheight-med-->--boxel-lineheight-md--boxel-font-med-->--boxel-font-md--boxel-icon-med-->--boxel-icon-md-2xsinstead of-xxs:example:
--boxel-lsp-xxl-->--boxel-lsp-2xl--boxel-border-radius-xxs-->--boxel-border-radius-2xs--boxel-sp-xxxl-->--boxel-sp-3xl--boxel-purple-and--boxel-light-) and added some missing colors to the color palette:--boxel-150: #f4f4f4;(formerly --boxel-light-100)--boxel-250: #d3d3d3;--boxel-425: #acacac;Note: there is still support for the old
-spvalues, but slowly phasing them out.The rest of the PR changes are replacing the places the non-supported variables are used.