feat: migrate settings to Obsidian 1.13 API + minor fixes - #13
Open
carlrobert wants to merge 2 commits into
Open
feat: migrate settings to Obsidian 1.13 API + minor fixes#13carlrobert wants to merge 2 commits into
carlrobert wants to merge 2 commits into
Conversation
- feat: migrate settings to Obsidian 1.13 API + minor fixes contributed by TyceHerrman, keeping legacy code as is - add punctuation to make the Obsidian plugin dashboard happy - remove package-beta.json, which is no longer used by BRAT - update dependencies
carlrobert
force-pushed
the
settings-api-etc
branch
from
July 26, 2026 08:30
8e09403 to
0577e46
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin to target the Obsidian 1.13 API (notably around settings metadata) and aligns dependency versions accordingly, alongside a few small metadata/documentation tweaks.
Changes:
- Pin the
obsidiandev dependency to^1.13.0and update the lockfile to match. - Introduce
getSettingDefinitions()(Obsidian 1.13 settings definitions) and a theme-options helper inmain.ts. - Minor updates to plugin/readme metadata (thanks line, manifest name punctuation) and remove
manifest-beta.json.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates contributor thanks line. |
| package.json | Pins obsidian dependency to the 1.13 line. |
| package-lock.json | Lockfile updates resulting from the obsidian version change. |
| manifest.json | Adjusts displayed plugin name text (adds trailing period). |
| manifest-beta.json | Removes the beta manifest file. |
| main.ts | Adds Obsidian 1.13 settings definition metadata + helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.