Implement stopId and stopSequence to PIP Estimates endpoint#55
Open
Movs22 wants to merge 2 commits into
Open
Conversation
This change is useful on multi-stop requests (i.e. if someone were to send a request to this endpoint with all stops for a given terminal) as it makes it possible to identify the corresponding stop for each estimate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Re)Added the stopId and added stopSequence to the PIP estimates endpoint.
stopId was marked as deprecated, however, this property is useful on multi-stop requests as it makes it possible to identify the stop corresponding to a given estimate.
An example use case where these properties would come in handy is, for example, fetching all estimates for a given terminal and displaying all of the estimates on a single web page WHILST identifying the stop (P1, P2...) of each estimate.