Skip to content

Upgrade deps#215

Open
calebeby wants to merge 3 commits intocarrot:masterfrom
calebeby:upgrade-deps
Open

Upgrade deps#215
calebeby wants to merge 3 commits intocarrot:masterfrom
calebeby:upgrade-deps

Conversation

@calebeby
Copy link
Copy Markdown
Contributor

No description provided.

@jescalan
Copy link
Copy Markdown
Contributor

why are all the returns removed?

@calebeby
Copy link
Copy Markdown
Contributor Author

calebeby commented Aug 25, 2017

https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#boom-breaking-changes

Resolution method is overspecified. Specify a callback or return a Promise; not both.

I was going through removing done in a bunch of places, but then it gave me an error, so I just removed the returns instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants