Skip to content

Fix: Prevent double MethodChannel result in Carrot.setup #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1leary1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent double MethodChannel result in Carrot.setup #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 43 additions & 19 deletions android/src/main/kotlin/io/carrotquest/carrotquest_sdk/CarrotquestSdkPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package io.carrotquest.carrotquest_sdk

import java.util.concurrent.atomic.AtomicBoolean
import android.app.Activity
import android.content.Context
import android.graphics.drawable.Drawable
Expand Down Expand Up @@ -148,61 +148,85 @@ class CarrotquestSdkPlugin: FlutterPlugin, MethodCallHandler, ActivityAware {
override fun onDetachedFromActivityForConfigChanges() {
}

//=====
private fun setup(
@NonNull call: MethodCall,
@NonNull result: MethodChannel.Result,
) {
val replied = AtomicBoolean(false)

apiKey = call.argument<String?>("api_key")
if (apiKey == null) {
result.error("An error has occurred, the apiKey or appId is null.", null, null)
if (replied.compareAndSet(false, true)) {
result.error("API_KEY_NULL", "apiKey is null", null)
}
return
}

val con = activity ?: context
if (con != null) {
try {
Carrot.setup(con, apiKey!!, object : Carrot.Callback<Boolean> {
Carrot.setup(con, apiKey!!, object : Carrot.Callback<Boolean> {

override fun onResponse(r: Boolean?) {
val res = r ?: false

if (res) {
try {
val iconId = con.resources.getIdentifier("ic_cqsdk_notification", "drawable", con.packageName);
val iconId = con.resources.getIdentifier(
"ic_cqsdk_notification",
"drawable",
con.packageName
)

if (iconId == 0) {
Carrot.setNotificationIcon(R.drawable.ic_cqsdk_def_notification)
} else {
Carrot.setNotificationIcon(iconId)
}

Carrot.setUnreadConversationsCallback(object : Callback<List<String>>{
Carrot.setUnreadConversationsCallback(object : Callback<List<String>> {
override fun onResponse(unreadConversationsIds: List<String>?) {
channel.invokeMethod("unreadConversationsCount", unreadConversationsIds?.size ?: 0)
channel.invokeMethod(
"unreadConversationsCount",
unreadConversationsIds?.size ?: 0
)
}

override fun onFailure(t: Throwable?) {

}
override fun onFailure(t: Throwable?) {}
})
} catch (e: java.lang.Exception) {

} catch (e: Exception) {
println("$e")
}
result.success("true")

if (replied.compareAndSet(false, true)) {
result.success("true")
}

} else {
result.success("false")
if (replied.compareAndSet(false, true)) {
result.success("false")
}
}
}

override fun onFailure(t: Throwable?) {
result.success("false")
if (replied.compareAndSet(false, true)) {
result.success("false")
}
}
})


} catch(e: java.lang.Exception) {
result.success("false")

} catch (e: Exception) {
if (replied.compareAndSet(false, true)) {
result.success("false")
}
}

} else {
result.success("false")
if (replied.compareAndSet(false, true)) {
result.success("false")
}
}
}

Expand Down