desk: version-stamp the look so an asset change re-seeds existing desks - #1
Merged
Merged
Conversation
The volume outlives the image and IS the computer's identity, so a desk created before a look change keeps its old xfconf files; the missing-only seed skips every one and the new wallpaper/panel/dock sits unused in the image. LOOK=v2 + a ~/.config/.case-look stamp: a bump force-seeds each desk once (resetting desktop tweaks that one time), then reverts to missing-only so user tweaks survive. Bump LOOK whenever image/assets change. Also normalize DESK_RESOLUTION: Xvfb needs WxHxD and exits 1 on bare WxH, so append x24 when depth is missing — 24 is the only depth deskd's XWD->PNG grab (32bpp) supports. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The home volume outlives the image and is the computer's identity (
lifecycle.py: "container is cattle, the volume is the identity"). A desk created before a look change already has xfconf files on its volume, sostart.sh's missing-onlyseed()skips every seed — the new wallpaper, panel layout, and dock launchers sit unused in the image while the desk keeps rendering the old look. Recreating the container doesn't help; only a brand-new volume would.Fix
LOOK=v2plus a~/.config/.case-lookstamp:cp -fpass, then the stamp is writtenBump
LOOKwheneverimage/assets/changes; every existing desk re-seeds exactly once (resetting desktop tweaks that one time), then goes back to leaving the user alone.Also normalizes
DESK_RESOLUTION: Xvfb exits 1 on bareWxH, so a missing depth getsx24appended — 24 being the only depth deskd's XWD→PNG grab (32bpp) supports.Verified
bash -nclean🤖 Generated with Claude Code