Replace derivative with derive-where#2465
Merged
casey merged 2 commits intocasey:masterfrom Nov 16, 2024
laniakea64:derive-where
Merged
Replace derivative with derive-where#2465casey merged 2 commits intocasey:masterfrom laniakea64:derive-where
derivative with derive-where#2465casey merged 2 commits intocasey:masterfrom
laniakea64:derive-where
Conversation
Owner
|
Nice, great PR! If you look at the |
Owner
|
Just measured it and build time went down from ~34.5s to ~32.5 seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
cargo auditonjustrepo gives the following warnings -This PR fixes one of these two warnings by replacing
derivativewithderive-where, which is howrustchandled this.