Skip to content

Download installer archive before decompression - #604

Open
richardchesse wants to merge 1 commit into
cashapp:masterfrom
richardchesse:codex/download-installer-before-decompress
Open

Download installer archive before decompression#604
richardchesse wants to merge 1 commit into
cashapp:masterfrom
richardchesse:codex/download-installer-before-decompress

Conversation

@richardchesse

Copy link
Copy Markdown

Summary

  • download the compressed Hermit binary to a temporary archive before decompressing it
  • keep user curl configuration enabled without allowing --write-out diagnostics to corrupt the archive stream
  • remove partial downloads on curl errors and reject missing or empty archives
  • keep both embedded installer templates synchronized

Why

The installer previously piped curl's stdout directly into gzip. If a user's curlrc configured diagnostic output with --write-out, those bytes were mixed into the archive stream and decompression failed. Disabling curlrc globally, as proposed in #603, avoids the symptom but also ignores every user's curl configuration. Downloading to a file isolates the response body while preserving curlrc behavior.

Validation

  • ./bin/go test ./...
  • generated-installer parity check
  • Shellcheck on the generated installer
  • regression harness with curlrc --write-out output
  • rejection test for a zero-byte download

Co-authored-by: Codex <noreply@openai.com>
Ai-assisted: true
@richardchesse
richardchesse marked this pull request as ready for review August 11, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant