Fix activation PATH shadowing - #609
Merged
Merged
Conversation
Use trusted system helper paths because environment bin directories are prepended before activation completes, allowing committed executables to shadow date, uname, or basename. Co-authored-by: Codex <noreply@openai.com>
Add an integration regression test proving that a repository-provided bin/date is accepted by validation but not executed while Hermit activates the environment. Co-authored-by: Codex <noreply@openai.com>
Use Bash OSTYPE so the launcher identifies macOS and Linux without executing a PATH-shadowable helper whose absolute location differs by platform. Record only the final canary and stable launcher hashes. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent Hermit's own activation helpers from resolving through an environment bin directory that has already been prepended to PATH. The activation templates invoke
/bin/date, the launcher uses Bash'sOSTYPEinstead ofuname, andbasenameis invoked by its trusted system path.Adds unit coverage for the affected activation paths and an integration regression proving a repository-provided
bin/datepasses validation but is not executed during bash or zsh activation.Co-authored-by: Codex noreply@openai.com