Harden source URL and archive parsing - #612
Merged
Merged
Conversation
alecthomas
force-pushed
the
aat/fix-dx-35
branch
from
August 13, 2026 03:30
a63a799 to
e0ef2bd
Compare
alecthomas
changed the title
Reject env source paths that escape the environment root, use exact tar type matching so regular files cannot be mistaken for links, and require the real github.com host for release URLs. Add regression and integration coverage so these security-sensitive behaviors remain enforced. Co-authored-by: Codex <noreply@openai.com>
alecthomas
force-pushed
the
aat/fix-dx-35
branch
from
August 13, 2026 03:51
e0ef2bd to
7254c9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DX-35.
Rejects
env://paths that escape the environment root, prevents regular tar entries with stray link names from being converted into symlinks, and restricts private GitHub release detection to the realgithub.comhost. These checks prevent out-of-root manifest loading and preserve archive contents and source-selection behavior.Adds focused regressions plus an end-to-end archive extraction test for the security-sensitive behavior, and documents that security fixes require integration coverage.