Prevent source credentials leaking to output - #615
Open
alecthomas wants to merge 3 commits into
Open
Conversation
Keep source URIs wrapped until raw access is explicitly required so logging, status, validation errors, and failed git commands cannot accidentally expose embedded credentials. Co-authored-by: Codex <noreply@openai.com>
Wrap source URIs at ingress and retain the Source type until parsing, network, filesystem, or process execution requires raw access. This makes credential-safe formatting the default and prevents intermediate strings from bypassing redaction. Co-authored-by: Codex <noreply@openai.com>
Name the credential-safe URI wrapper SourceURI so the established sources.Source interface does not need an unrelated public rename. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourceURIwrapper whoseString()representation redacts credentials and whose explicitGet()method returns the raw URI.sources.Sourceinterface while wrapping manifest and package source URIs at ingress, then carrySourceURIthrough URL rewriting, cache selectors, Git and HTTP source implementations, validation, status output, and command execution.@.Testing
GitHubTokenIsRedactedFromOutputintegration coverage for status, debug, validation, command output, and error paths.Linear: DX-26