fix(tools): use Schema.optionalKey and fix Cmd+C copy - #13
Merged
Merged
Conversation
- Schema.optional produces Union(T | Undefined) which OpenRouter and Anthropic structured output reject - Schema.optionalKey marks the key as optional without adding Undefined to the AST - Fix Cmd+C copy: with Kitty keyboard protocol, Cmd maps to key.super, not key.meta (which is Alt/Option)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema.optionalwithSchema.optionalKeyin all tool definitions to avoid theUndefinedAST node that OpenRouter and Anthropic structured output reject (Google was unaffected).key.super, notkey.meta(which is Alt/Option).