Skip to content

prefer sendBeacon to XMLHttpRequest #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlisliu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

prefer sendBeacon to XMLHttpRequest #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e87c709
prefer sendBeacon to xhr
carlisliu Oct 10, 2016
a261913
update version
carlisliu Oct 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "tracker_client",
"version": "0.2.0",
"version": "0.2.1",
"description": "a flexble client error and action track script",
"main": "src/index.js",
"directories": {
Expand Down
16 changes: 12 additions & 4 deletions src/dispatcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,20 @@ dispatcher.prototype = {
},
sendError: function(info) {
var endPoint = this.endPoint(this.config.token)
var xhr = getXHR(endPoint)
if (util.isString(info)) {
xhr.send(info)
if (!util.isString(info)) {
info = JSON.stringify(info)
}
if (navigator.sendBeacon) {
/*
* https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon
* This method addresses the needs of analytics and diagnostics code that typically attempts to send data to a web server prior to the unloading of the document.
* user agents typically ignore asynchronous XMLHttpRequests made in an unload handler
*/
navigator.sendBeacon(endPoint, info);
}
else {
xhr.send(JSON.stringify(info))
var xhr = getXHR(endPoint)
xhr.send(info)
}
}
}
Expand Down