Write blocks to temp files and move atomically - #3232
Open
eclark0426 wants to merge 1 commit into
Open
eclark0426 wants to merge 1 commit into
eclark0426 wants to merge 1 commit into
Conversation
eclark0426
requested review from
andr-dev,
ariqchowdhury,
michael-yxchen,
omegablitz and
philipglazman
as code owners
August 28, 2026 16:16
eclark0426
force-pushed
the
ellis/fs-atomic-writes
branch
from
August 28, 2026 16:16
98cf521 to
b106bfb
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the filesystem-backed KV store to write values into a staging (temp) directory and then publish them via an atomic filesystem operation, reducing the chance of readers observing partially-written files.
Changes:
- Added a
.tmpstaging directory plus unique temp-file naming for staged writes. - Reworked
putto write into staging and thenrenameinto place; updated directory scans to avoid descending into.tmp. - Added tests asserting staging is hidden from scans, cleaned up after writes, and not created by reads.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eclark0426
force-pushed
the
ellis/fs-atomic-writes
branch
from
August 28, 2026 18:50
b106bfb to
801f578
Compare
eclark0426
force-pushed
the
ellis/fs-atomic-writes
branch
from
August 28, 2026 18:52
801f578 to
efa4582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.