feat(ledger-tail): log gas_used on proposed_block - #3250
Closed
johnmarcou wants to merge 1 commit into
Closed
johnmarcou wants to merge 1 commit into
johnmarcou wants to merge 1 commit into
Conversation
johnmarcou
marked this pull request as ready for review
September 9, 2026 15:39
johnmarcou
requested review from
ariqchowdhury,
dshulyak,
michael-yxchen,
omegablitz and
xinyuan-dev
as code owners
September 9, 2026 15:39
Contributor
|
@omegablitz do you mind reviewing this for @johnmarcou (MF)? |
omegablitz
approved these changes
Sep 10, 2026
michael-yxchen
approved these changes
Sep 10, 2026
rtsaimonad
enabled auto-merge
September 17, 2026 15:57
Post-MONAD_ONE, unused-gas refunds are hardcoded to 0, so a block's gas_used equals the sum of its transactions' gas_limit exactly. This lets proposed_block report gas_used directly from the proposal's tx list, without waiting on asynchronous execution output. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
auto-merge was automatically disabled
September 17, 2026 21:00
Head branch was pushed to by a user without write access
johnmarcou
force-pushed
the
john/ledger-tail-gas-used-sum
branch
from
September 17, 2026 21:00
40cd85a to
99bcdfe
Compare
michael-yxchen
approved these changes
Sep 17, 2026
Contributor
|
Superceded by #3271 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements gas_used reporting in ledger-tail's proposed_block log event.
gas_usedfield to theproposed_blocktracing log line, alongside the existingnum_txgas_limit, since post-MONAD_ONE unused-gas refunds are hardcoded to 0, making gas_used == gas_limit exactly for every transactionalloy-consensusas a dev-dependency ofmonad-nodeto bring theTransactiontrait (.gas_limit()) into scope for the example binary