Add RLP serialization for Cadence protocol messages - #3252
Open
michael-yxchen wants to merge 1 commit into
Open
michael-yxchen wants to merge 1 commit into
michael-yxchen wants to merge 1 commit into
Conversation
Implement Alloy RLP encoding and decoding for CadenceMessage and its Chorus, Conductor, and MVBA payloads. Use tagged lists for enums and transparent encoding for wrappers, rejecting unknown tags and extra data. Define Serializable and Deserializable in the Chorus spec and implement the byte interface for CadenceMessage without a monad-types dependency. Parameterize MVBA votes, certificates, and block requests directly by entries rather than by the votable value, and replace tuple scopes with ProposalScope and MvbaScope so codecs bind the actual wire fields. Cover concrete Cadence envelopes, message variants, optional certificates, wrapper layouts, and malformed input with round-trip tests. This code was generated using Codex (GPT-6) and Claude Fable 5.1.
michael-yxchen
requested review from
andr-dev,
ariqchowdhury,
dshulyak,
eclark0426,
omegablitz and
xinyuan-dev
as code owners
September 10, 2026 18:49
michael-yxchen
added this pull request to stack #3256
September 14, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Alloy RLP encoding and decoding for CadenceMessage and its Chorus, Conductor, and MVBA payloads. Use tagged lists for enums and transparent encoding for wrappers, rejecting unknown tags and extra data.
Define Serializable and Deserializable in the Chorus spec and implement the byte interface for CadenceMessage without a monad-types dependency.
Parameterize MVBA votes, certificates, and block requests directly by entries rather than by the votable value, and replace tuple scopes with ProposalScope and MvbaScope so codecs bind the actual wire fields.
Cover concrete Cadence envelopes, message variants, optional certificates, wrapper layouts, and malformed input with round-trip tests.
This code was generated using Codex (GPT-6) and Claude Fable 5.1.